| Horde3D http://www.horde3d.org/forums/ |
|
| parseFXSection buffer overrun http://www.horde3d.org/forums/viewtopic.php?f=3&t=1169 |
Page 1 of 1 |
| Author: | attila [ 30.05.2010, 15:50 ] |
| Post subject: | parseFXSection buffer overrun |
In ShaderResource::parseFXSection the comment replacer code can cause buffer overrun if there is a non-closed /* comment at the end of the buffer. Ending zero should be checked in the inner loop. I couldn't create a problematic test case with // comment but a check for 0 in that inner loop wouldn't hurt either. |
|
| Author: | Volker [ 03.06.2010, 19:05 ] |
| Post subject: | Re: parseFXSection buffer overrun |
Thanks for pointing that out, should be fixed now in the trunk. |
|
| Page 1 of 1 | All times are UTC + 1 hour |
| Powered by phpBB® Forum Software © phpBB Group https://www.phpbb.com/ |
|